Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euro 2024: Three groups to a row instead of four #27223

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Jun 13, 2024

What does this change?

Reduces the number of items in a row from 4 to 3 on the Euro 2024 groups

Why?

Readability

Screenshots

Before After
before after

Checklist

@domlander domlander force-pushed the doml/euros-group-styles branch from 0872541 to 50d3402 Compare June 13, 2024 16:30
@domlander domlander force-pushed the doml/euros-group-styles branch from 50d3402 to e37aa08 Compare June 13, 2024 16:31
@domlander domlander marked this pull request as ready for review June 13, 2024 16:46
@domlander domlander requested a review from a team as a code owner June 13, 2024 16:46
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would look better to have 4 if there were 8 groups? One for a future competition.

@domlander domlander merged commit 40f2c62 into main Jun 13, 2024
3 checks passed
@domlander domlander deleted the doml/euros-group-styles branch June 13, 2024 17:25
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @domlander 10 minutes and 58 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @domlander 12 minutes and 3 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants