Euro 2024 atom header #27220
Merged
Euro 2024 atom header #27220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor the code for readability and make the iframe look better Co-Authored-By: Dom Lander <[email protected]>
reduce the total diff of this change
mxdvl
approved these changes
Jun 13, 2024
Comment on lines
+26
to
+27
| GET /football/:tag/fixtures football.controllers.FixturesController.tagFixtures(tag) | ||
| GET /football/:tag/fixtures.json football.controllers.FixturesController.tagFixturesJson(tag) |
There was a problem hiding this comment.
Both of these methods return the same thing, but fixed for consistency
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (created by @domlander and merged by @mxdvl 11 minutes and 5 seconds ago)
|
|
Seen on FRONTS-PROD (created by @domlander and merged by @mxdvl 11 minutes and 15 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Make the Euro 2024 stand out and be consistent across all relevant pages.
Part of guardian/dotcom-rendering#11553
What does this change?
Insert the euro 2024 header interactive atom on selected sport pages.
Screenshots
Checklist