Use service account for connecting to Google Ad Manager API #27213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-imber
approved these changes
Jun 13, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @Jakeii 12 minutes and 5 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @Jakeii 13 minutes and 9 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Current authentication is tied to a user account of someone on the commercial team.
If for whatever reason their account is removed (when they leave) or they no longer need access to GAM (by changing teams) the credentials stop working and they need to be replaced.
This has happend a few times over the years, by changing to a service account we can stop this mildly inconvenient thing happening now and again!
What does this change?
Replace client id/secret and refresh token with a service account JSON file (still stored in parameter store).
The SDK will only accept a file path so the token is written as a temporary file and then cleaned up using the stop hooks.
Checklist