Replace Listr with Listr2 #27154
Merged
Replace Listr with Listr2 #27154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the aptly named listr2 is actually maintained Co-authored-by: Anna Beddow <[email protected]> Co-authored-by: Jamie B <[email protected]> Co-authored-by: Ioanna Kokkini <[email protected]> Co-authored-by: Dom Lander <[email protected]>
mxdvl
force-pushed
the
mob/update-ansi-regex
branch
from
50e16a0 to
4394693
Compare
JamieB-gu
approved these changes
May 16, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @mxdvl 13 minutes and 9 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @mxdvl 13 minutes and 15 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
In that version, Listr is the goodie, not the baddie. The baddie is a soft-metal robot that tries to kill … wait no that’s the plot of Terminator 2.
Listr2 is a TS rewrite of Listr and is actually maintained. We use this dep under the hood in other repos such as dotcom-rendering via
lint-staged.