Reinstate affiliate links for all eligible DCR articles behind a 0% test #27150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiAdcock
reviewed
May 16, 2024
| ) | ||
| def shouldAddAffiliateLinks(content: ContentType)(implicit request: RequestHeader): Boolean = { | ||
| val contentHtml = Jsoup.parse(content.fields.body) | ||
| val bodyElements = contentHtml.select("body").first().children() |
There was a problem hiding this comment.
Non blocking: I'm not wedded to this suggestion, and I'm not sure of the best place, but would an explanatory comment help?
Suggested change
| val bodyElements = contentHtml.select("body").first().children() | |
| val bodyElements = contentHtml.select("body").first().children() | |
| /** | |
| * On smaller devices, the disclaimer is inserted before paragraph 2 of the article body and floats left. | |
| * This logic ensures there are two clear paragraphs of text at the top of the article. | |
| * We don't support inserting the disclaimer next to other element types. | |
| * It also ensures the second paragraph is long enough to accommodate the disclaimer appearing alongside it. | |
| */ | |
SiAdcock
approved these changes
May 16, 2024
dskamiotis
approved these changes
May 16, 2024
There was a problem hiding this comment.
Tested thoroughly in CODE and working as expected.
Available documentation on results of testing: here
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @emma-imber 12 minutes and 11 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @emma-imber 15 minutes and 28 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Reinstates affiliate links for all eligible DCR articles behind a 0% test. We've added a 0% server side test, and we check if a user is in the variant before considering a DCR article published after the cutoff date that isn't on the allowlist. For anyone not in the variant, the allowlist and cutoff date still apply for DCR rendered articles.
We now check that the first two elements in the body content of a DCR article are both paragraph elements. This ensures that the disclaimer doesn't clash with thumbnail images or rich links. We also check that the second paragraph element is over 250 characters. This is to make sure that there is enough text to wrap around the disclaimer if an image was to follow next, so that we don't get unwanted whitespace on the page. These checks should ensure that the DCR version of the disclaimer doesn't negatively impact the UI. These checks apply to articles in the allowlist and before the cutoff date, as they will improve the page experience for everyone.
Screenshots
Disclaimer on mobile:
Affiliate links not inserted to avoid disclaimer clashing with thumbnail image on mobile:
If we didn't have the check, the disclaimer would look like this:
Affiliate links not inserted to avoid disclaimer clashing with thumbnail image on desktop:
If we didn't have this check, the disclaimer would look like this: