Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout DCR video pages (behind switch) #27149

Merged
merged 2 commits into from
May 16, 2024
Merged

Rollout DCR video pages (behind switch) #27149

merged 2 commits into from
May 16, 2024

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented May 15, 2024

What does this change?

Rollout DCR rendered video pages to 100% of users, behind a feature switch just in case.

@Jakeii Jakeii marked this pull request as ready for review May 16, 2024 10:04
@Jakeii Jakeii requested a review from a team as a code owner May 16, 2024 10:04
Copy link
Contributor

@deedeeh deedeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me but I agree with you to let WebX have a look as well.

@mxdvl
Copy link
Contributor

mxdvl commented May 16, 2024

As noted by @cemms1, there’s a low-contrast issue on “About this content” for branded videos such as this one:

image

Fixed by guardian/dotcom-rendering#11436

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @Jakeii 16 minutes and 7 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants