use lazy val for single PanDomainAuthSettingsRefresher #27109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeblahblah
approved these changes
May 3, 2024
alinaboghiu
approved these changes
May 3, 2024
twrichards
approved these changes
May 7, 2024
There was a problem hiding this comment.
excellent catch @andrew-nowak and I know you've tested in CODE - thank you
I'm going to merge this now, as I'm back working today and can monitor it rolling out...
|
Seen on FRONTS-PROD, ADMIN-PROD (created by @andrew-nowak and merged by @twrichards 11 hours, 30 minutes and 25 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
#27108 fails at runtime because it cannot be constructed immediately - the val must be
lazyto allow items to be constructed in the correct orderChecklist