[email protected], fix peer deps, upgrades and fixes #27086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seen on ADMIN-PROD (merged by @arelra 11 minutes and 53 seconds ago)
|
prout-bot
added
Seen-on-ADMIN-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @arelra 12 minutes ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update TypeScript to v5.3.3 to align with @guardian/commercial.
Fixing all peer dependencies became a thread pulling exercise of also updating: @guardian packages, eslint, babel, react, jest etc and fixing ensuing TS, babel and jest issues.
There's probably more upgrades we could do but this PR just fixes all peer deps and resulting errors from the TS upgrade.
The client side code in Frontend is mostly deprecated, it only runs on pages that Frontend still renders and the commercial codebase still runs on (primarily tag pages, video, audio and galleries atm).
Checklist