Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update post-merge message when Node version changes #27085

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

arelra
Copy link
Member

@arelra arelra commented Apr 29, 2024

What does this change?

Update the post-merge git hook message when .nvmrc changes to include examples of how to change node version with more modern node version managers.

Aligns with the post-merge hook message in DCR

Before:

Frontend now requires Node 20.12.2
. Switch to the latest version using `nvm install` or download from nodejs.org. Then run `make reinstall`.

After:

Frontend now requires Node 20.12.2
Switch to the latest version using `nvm use`, `fnm use` or `asdf install` (or whatever is appropriate) or download from nodejs.org. Then run `make reinstall`.

@arelra arelra requested a review from a team as a code owner April 29, 2024 14:46
@arelra arelra merged commit 1e2382f into main Apr 29, 2024
3 checks passed
@arelra arelra deleted the ravi/node-change-msg branch April 29, 2024 17:27
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @arelra 12 minutes ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @arelra 14 minutes and 9 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants