Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source in DCR data model #27077

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Fix source in DCR data model #27077

merged 5 commits into from
Apr 25, 2024

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Apr 25, 2024

What is the value of this and can you measure success?

At the moment this property is always an empty string for newer video pages using youtube.

This fix will allow showing the source of the media on DCR rendered video pages which use the youtube atom.

This is the source from frontend rendered page that we need to render in DCR
Screenshot 2024-04-25 at 11 40 08

What does this change?

elements.videos appears to be where the media elements are on old non-youtube video articles like https://www.theguardian.com/film/video/2013/aug/14/chloe-grace-moretz-kick-ass-2-video

For newer aticles like https://www.theguardian.com/global/video/2024/apr/25/160-pilot-whales-stranded-and-26-confirmed-dead-in-western-australia-video it's in content.media, using the first item in it seems logical.

Screenshots

Before After
before after

Checklist

@Jakeii Jakeii requested a review from a team as a code owner April 25, 2024 11:15
@Jakeii Jakeii marked this pull request as draft April 25, 2024 11:27
@Jakeii Jakeii marked this pull request as ready for review April 25, 2024 13:00
@Jakeii Jakeii merged commit afdcd77 into main Apr 25, 2024
3 checks passed
@Jakeii Jakeii deleted the jlk/fix-source-prop-dcr-data-model branch April 25, 2024 15:37
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @Jakeii 52 minutes and 32 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants