Show affiliate links on all eligible galleries #27071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
approved these changes
Apr 24, 2024
SiAdcock
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Awesome work @emma-imber 🎉 This is actually a 👍 from me!
⛔ To anyone reading: please don't merge until comms are sent 😄
UPDATE: we are good to merge on Monday 29th April
SiAdcock
approved these changes
Apr 26, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-FRONTS-PROD
and removed
Pending-on-FRONTS-PROD
labels
|
Seen on FRONTS-PROD (merged by @emma-imber 19 minutes and 31 seconds ago)
|
|
Seen on ADMIN-PROD (merged by @emma-imber 19 minutes and 36 seconds ago)
|
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Adding affiliate links to more galleries will increase the number of affiliate links on the site, so will have a revenue benefit associated.
What does this change?
We now want to launch skimlinks on all eligible galleries, and no longer use an allowlist for gallery content. We now pass in a
contentTypeparameter to the shouldAddAffiliateLinks check, and if thecontentTypeis gallery, we don't perform the allowlist or cut off date check. Note that we still need these checks for DCR rendered articles with affiliate links, as we're still in the process of finding the best way to insert the DCR disclaimer so that it doesn't clash with other page elements, so we're only making affiliate links available on a limited number of DCR pages. The gallery disclaimer design is simpler as it's contained about the main page content, so we don't have the same issues.Screenshots
Disclaimer now being added to a gallery which isn't on the allowlist and is published after the cut-off date.