Enhance timeline elements with ids #27055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeddow91
force-pushed
the
ab/enhance-timeline
branch
from
85a9d49 to
8aa5ec8
Compare
abeddow91
force-pushed
the
ab/enhance-timeline
branch
from
0acc43f to
876c631
Compare
mxdvl
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Nice – bar the fact that elementId does not bring much value…
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @abeddow91 11 minutes and 7 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Enhances the timeline element so that each child element has an element id. This is required for the DCR to correctly match the elements with its schema.
It also refactors the ElementsEnhancer using pattern matching and adds comments to help improve readability.
It also renames enhanceObjectWithElementsAtDepth1 => enhanceObjectsWithElements as we are no longer limiting the function to only going to a depth of 1.
Screenshots
Data Structure
Article
Checklist