Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump commercial #26978

Merged
merged 1 commit into from
Mar 19, 2024
Merged

bump commercial #26978

merged 1 commit into from
Mar 19, 2024

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Mar 19, 2024 •
edited
Loading

Minor Changes

  • 6d621db: Fix a bug with spacefinder avoiding other ads on mobile
  • 6d621db: Add "high value sections" ab test, increasing ad density on articles in high value sections

Patch Changes

  • 6d621db: Fix bug with spacefinder avoiding sfdebug elements
  • be423b1: adds the 2x2 slot to allow the mobile-sticky to be empty

Full Changelog

@Jakeii Jakeii requested a review from a team as a code owner March 19, 2024 12:44
@github-actions GitHub Actions
Copy link
Contributor

Deploy build 1373 of dotcom:frontend-all to CODE

All deployment options

From guardian/actions-riff-raff.

@Jakeii Jakeii changed the title Bump commercial to 17.4.0 bump commercial Mar 19, 2024
@Jakeii Jakeii merged commit 5b43eca into main Mar 19, 2024
3 checks passed
@Jakeii Jakeii deleted the jlk/bump-commercial-17.4.0 branch March 19, 2024 14:53
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @Jakeii 11 minutes and 45 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @Jakeii 11 minutes and 51 seconds ago)

Jakeii added a commit that referenced this pull request Mar 19, 2024
@Jakeii
Revert "bump commercial (#26978)"
beed71c 
This reverts commit 5b43eca.
@Jakeii Jakeii mentioned this pull request Mar 19, 2024
Merged
@Jakeii Jakeii restored the jlk/bump-commercial-17.4.0 branch March 19, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlander domlander domlander approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jakeii @prout-bot @domlander