Add facia baseURL to config and use in DCR service #26858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
cemms1/use-facia-rendering-service
branch
from
450fb6b to
ffca594
Compare
mxdvl
approved these changes
Jan 31, 2024
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @cemms1 11 minutes and 10 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @cemms1 12 minutes and 45 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Starts sending traffic to the new
facia-renderingDCR app for fronts and tag pagesResolves guardian/dotcom-rendering#9323
Important
guardian/dotcom-rendering#10386 must be merged first as it launches the app and sets the relevant parameter store configuration
What does this change?
Adds value for
facia-renderingbase URL in the configuration and then uses this in theDotcomRenderingServicefor DCR requests to/Frontand/TagFrontChecklist
Meets our accessibility standardsTested with screen readerNavigable with keyboardColour contrast passed