Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dark-mode-apps switch on client side #26733

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Expose dark-mode-apps switch on client side #26733

merged 3 commits into from
Dec 1, 2023

Conversation

georgeblahblah
Copy link
Contributor

Only switches with exposeClientSide=true are passed to DCR.

frontend/common/app/model/dotcomrendering/DotcomBlocksRenderingDataModel.scala

Lines 94 to 98 in ea78dc5

val switches: Map[String, Boolean] = conf.switches.Switches.all
.filter(_.exposeClientSide)
.foldLeft(Map.empty[String, Boolean])((acc, switch) => {
acc + (CamelCase.fromHyphenated(switch.name) -> switch.isSwitchedOn)
})

@georgeblahblah
Expose dark-mode-apps switch on client side
27f96db 
Only switches with `exposeClientSide=true` are passed to DCR.
@georgeblahblah georgeblahblah requested a review from a team as a code owner December 1, 2023 11:16
mxdvl
mxdvl approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good ol’ gotcha!

@cemms1
Copy link
Contributor

cemms1 commented Dec 1, 2023

I didn't know this! But I was wondering why switches weren't pulling through as expected locally 😄

@georgeblahblah
Copy link
Contributor Author

I'll also take this opportunity to rename the switch in Frontend.

We've referred to it as darkModeInApps in DCR, but it's coming through as darkModeApps.

@georgeblahblah georgeblahblah merged commit a06fec0 into main Dec 1, 2023
2 checks passed
@georgeblahblah georgeblahblah deleted the gb/expose-darkmode-switch-dcr branch December 1, 2023 14:45
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @georgeblahblah 11 minutes and 28 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @georgeblahblah 12 minutes and 34 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannakok ioannakok ioannakok approved these changes

@mxdvl mxdvl mxdvl approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@georgeblahblah @cemms1 @prout-bot @mxdvl @ioannakok