Set printable crossword cache time to 60 secs #26688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally we needed to update the crossword data after publication. This happened recently, and while the interactive/playable crossword was very fast to update, we received some comments (https://www.theguardian.com/crosswords/cryptic/29227#comment-165327727, and others) that the `/print` version remained out of date. I was able to request a cache purge for the page to correct it in this circumstance, but it would be preferable if the cache time was sufficiently short that updates propagated quickly without intervention.
mxdvl
reviewed
Nov 14, 2023
mxdvl
approved these changes
Nov 14, 2023
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @andrew-nowak 16 minutes and 50 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @andrew-nowak 19 minutes and 2 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally we need to update the crossword data after publication. This happened recently, and while the interactive/playable crossword was very fast to update, we received some comments (https://www.theguardian.com/crosswords/cryptic/29227#comment-165327727, and others) that the
/printversion remained out of date. I was able to request a cache purge for the page to correct it in this circumstance, but it would be preferable if the cache time was sufficiently short that updates propagated quickly without intervention.What is the value of this and can you measure success?
Users see the corrected page very quickly, and are not relying on developers watching comments to remember to purge the cache for the page. The new max-cache matches the value for other crossword pages, including the main page and accessible pages and the thumbnail endpoint. I don't believe these pages see a huge amount of traffic, so I wouldn't expect this to cause a significantly increased resource usage.
I looked through the commit history for this line, and it has been unchanged since the page was implemented and no rationale was given for this specific value.
Checklist