Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NavLinks): add Ukraine to US Edition #26671

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Nov 2, 2023

What is the value of this and can you measure success?

Follow-up on Editorial request and #26666

What does this change?

Add Ukraine to the US Edition SubNav

Screenshots

image image image image

Checklist

@mxdvl mxdvl added the Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. label Nov 2, 2023
@mxdvl mxdvl self-assigned this Nov 2, 2023
@mxdvl mxdvl force-pushed the mxdvl/nav-links-add-ukraine-us branch from 0a9b528 to c7cae9a Compare November 2, 2023 09:50
@mxdvl mxdvl force-pushed the mxdvl/nav-links-add-ukraine-us branch from c7cae9a to 7f9ff94 Compare November 2, 2023 09:52
@mxdvl mxdvl marked this pull request as ready for review November 2, 2023 10:25
@mxdvl mxdvl requested a review from a team as a code owner November 2, 2023 10:25
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxdvl mxdvl merged commit 344226b into main Nov 2, 2023
2 checks passed
@mxdvl mxdvl deleted the mxdvl/nav-links-add-ukraine-us branch November 2, 2023 10:39
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (merged by @mxdvl 11 minutes and 51 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rota Any issues that have come in as part of rota. Useful for the person on rota to track their work. Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants