Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing subnav cartoons #26669

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Fix missing subnav cartoons #26669

merged 5 commits into from
Nov 2, 2023

Conversation

alinaboghiu
Copy link
Member

@alinaboghiu alinaboghiu commented Nov 2, 2023 •
edited
Loading

What does this change?

This ensures the subnav appears on the Cartoons tag page

Screenshots

Checklist

@alinaboghiu alinaboghiu marked this pull request as ready for review November 2, 2023 10:54
@alinaboghiu alinaboghiu requested a review from a team as a code owner November 2, 2023 10:54
mxdvl
mxdvl approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just missing a PR description.

PS. These massive json diffs really annoy me…

DanielCliftonGuardian
DanielCliftonGuardian approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@alinaboghiu
Copy link
Member Author

Thanks both. And I agree Max, hiding whitespace in the GH diff helps a bit.

@alinaboghiu alinaboghiu merged commit 730dd0f into main Nov 2, 2023
2 checks passed
@alinaboghiu alinaboghiu deleted the fix-missing-subnav-cartoons branch November 2, 2023 11:10
@prout-bot
Copy link
Collaborator

Seen on ADMIN-PROD (merged by @alinaboghiu 15 minutes and 53 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD (merged by @alinaboghiu 16 minutes and 12 seconds ago)

@alinaboghiu
Copy link
Member Author

@mxdvl sorry I completely forgot about description, have added some now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielCliftonGuardian DanielCliftonGuardian DanielCliftonGuardian approved these changes

@mxdvl mxdvl mxdvl approved these changes

Assignees
No one assigned
Labels
Seen-on-ADMIN-PROD Seen-on-FRONTS-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinaboghiu @prout-bot @mxdvl @DanielCliftonGuardian