Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump videoJS dependancies #26659

Closed
wants to merge 1 commit into from
Closed

Conversation

sophie-macmillan
Copy link
Contributor

What is the value of this and can you measure success?

Bumps videojs and videojs-ima packages.

We shouldn't merge this yet, as videojs-playlist now has an incorrect peer dependancy on videojs.

We would like to upgrade videojs-playlist as well, but its a guardian fork (https://github.com/guardian/videojs-playlist) and this fork is now deprecated.

Do we know why we forked the package, or why its now deprecated?

@sophie-macmillan
Copy link
Contributor Author

@sndrs appreciate it was a long time ago (2016!) but if you have any context on this that would be really useful please 🤞

Co-authored-by: Jamie B <[email protected]>
Co-authored-by: George B <[email protected]>
Co-authored-by: Ioanna Kokkini <[email protected]>
Co-authored-by: Charlotte Emms <[email protected]>
Co-authored-by: Max Duval <[email protected]>
Co-authored-by: Daniel Clifton <[email protected]>
Copy link
Contributor

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

@github-actions github-actions bot added the Stale label Nov 27, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant