Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AB Test definition #26646

Closed
wants to merge 5 commits into from
Closed

Add AB Test definition #26646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cef013
Add AB Test definition
lindseydew Oct 16, 2023
b50598e
Use prettier
lindseydew Oct 17, 2023
d598e28
Merge branch 'main' into ld-times-of-day-abtest
lindseydew Oct 17, 2023
2ff76e5
Update the expiry time to not fall on the weekend
lindseydew Oct 17, 2023
2f398ba
Update the audience figures and duration
lindseydew Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/app/conf/switches/ABTestSwitches.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ trait ABTestSwitches {
exposeClientSide = true,
)

Switch(
ABTests,
"ab-sign-in-gate-times-of-day",
"Show sign in gate a different frequency depending on the time of day",
owners = Seq(Owner.withGithub("personalisation")),
safeState = Off,
sellByDate = Some(LocalDate.of(2023, 11, 23)),
exposeClientSide = true,
)

Switch(
ABTests,
"ab-deeply-read-article-footer",
Expand Down
2 changes: 2 additions & 0 deletions static/src/javascripts/projects/common/modules/experiments/ab-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ import { prebidKargo } from './tests/prebid-kargo';
import { remoteRRHeaderLinksTest } from './tests/remote-header-test';
import { signInGateMainControl } from './tests/sign-in-gate-main-control';
import { signInGateMainVariant } from './tests/sign-in-gate-main-variant';
import { signInGateTimesOfDay } from './tests/sign-in-gate-times-of-day';

// keep in sync with ab-tests in dotcom-rendering
// https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/web/experiments/ab-tests.ts
export const concurrentTests: readonly ABTest[] = [
signInGateMainVariant,
signInGateMainControl,
signInGateTimesOfDay,
remoteRRHeaderLinksTest,
deeplyReadArticleFooterTest,
consentlessAds,
Expand Down
27 changes: 27 additions & 0 deletions ...ic/src/javascripts/projects/common/modules/experiments/tests/sign-in-gate-times-of-day.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@


export const signInGateTimesOfDay = {
id: 'SignInGateTimesOfDay',
start: '2023-10-23',
expiry: '2023-11-23',
author: 'Lindsey Dew',
description:
'Show sign in gate more frequently to users in the morning',
audience: 0.5,
audienceOffset: 0.4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main gate AB definition needs to be amended to match in frontend too.

successMeasure: 'Increase registration and sign ins by 5%',
audienceCriteria:
'1st article of the day, max 5 articles, lower priority than consent banner, simple articles (not gallery, live etc.), not signed in, not shown after dismiss, not on help, info sections etc. Exclude iOS 9 and guardian-live-australia. Suppresses other banners, and appears over epics',
ophanComponentId: 'morning',
dataLinkNames: 'SignInGateTimesOfDay',
idealOutcome:
'TODO',
showForSensitive: false,
canRun: () => true,
variants: [
{
id: 'morning',
test: () => {},
},
],
};
Loading