Set eager prebid test audience to 0% #26643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "@guardian/atom-renderer": "^2.0.0", | |||
| "@guardian/automat-modules": "^0.3.8", | |||
| "@guardian/braze-components": "^15.0.1", | |||
| "@guardian/commercial": "11.15.0", | |||
| "@guardian/commercial": "^11.16.0", | |||
There was a problem hiding this comment.
Is the addition of the caret intentional? I'm not against it's inclusion, just wanted to check.
There was a problem hiding this comment.
Ah good spot, no it wasn't. Will remove it!
emma-imber
force-pushed
the
ei/set-eager-prebid-to-0
branch
from
0f62507 to
31a0842
Compare
emma-imber
force-pushed
the
ei/set-eager-prebid-to-0
branch
from
066710d to
280ad41
Compare
SiAdcock
approved these changes
Oct 17, 2023
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @emma-imber 18 minutes and 12 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @emma-imber 18 minutes and 20 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bumps the version of the commercial bundle and sets the audience of the eager prebid test to 0%.
The test has now finished but we would like to retain the logic until we have the test results.