remove commercial BookOffersAPI #26615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakeii
force-pushed
the
jlk/delete-book-offers-api
branch
from
b32b1b1 to
a869acd
Compare
Jakeii
force-pushed
the
jlk/delete-book-offers-api
branch
2 times, most recently
from
2b40ba9 to
fcb2f6f
Compare
Jakeii
force-pushed
the
jlk/delete-book-offers-api
branch
from
fcb2f6f to
c2bcf09
Compare
arelra
approved these changes
Oct 2, 2023
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @Jakeii 15 minutes and 51 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @Jakeii 16 minutes and 57 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Less code to maintain
What does this change?
The service that drives this (a Magento shop, presumably the predecessor to the current book shop, which uses Bigcommerce) is dead, so this API has not worked for some time.
The upstream API was located at
https://www.guardianbookshop.com/api/rest/guardianproductsThe custom ad creatives that used this API appear to also be out of use.
Checklist