review refinements

guardian · Jan 29, 2024 · ce9eceb · ce9eceb
1 parent 30a184f
commit ce9eceb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala
@@ -64,13 +64,13 @@ trait ABTestSwitches {
     sellByDate = Some(LocalDate.of(2024, 1, 31)),
     exposeClientSide = true,
   )
-   Switch(
+  Switch(
     ABTests,
     "ab-crosswords-mobile-banner",
     "Test mobile banner in crossword pages.",
     owners = Seq(Owner.withEmail("[email protected]")),
     safeState = Off,
-    sellByDate = Some(LocalDate.of(2024, 1, 31)),
+    sellByDate = Some(LocalDate.of(2024, 2, 31)),
     exposeClientSide = true,
   )
 }
diff --git a/common/app/conf/switches/FeatureSwitches.scala b/common/app/conf/switches/FeatureSwitches.scala
@@ -538,7 +538,7 @@ trait FeatureSwitches {
     SwitchGroup.Feature,
     "crossword-mobile-banner",
     "If this switch is on, we will show an advert banner on mobile crossword pages",
-    owners = Seq(Owner.withEmail("dotcom.platform@theguardian.com")),
+    owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")),
     safeState = Off,
     sellByDate = Some(LocalDate.of(2024, 3, 15)),
     exposeClientSide = true,

diff --git a/static/src/javascripts/projects/common/modules/crosswords/crossword.js b/static/src/javascripts/projects/common/modules/crosswords/crossword.js
@@ -746,7 +746,7 @@ class Crossword extends Component {
         };
         // Trigger the custom event when component has loaded for ad slot in commercial
         useEffect(() => {
-            const customEvent = new CustomEvent('crosswordLoaded', {detail: {source: 'frontend_bundle'}});
+            const customEvent = new CustomEvent('crossword-loaded', {detail: {source: 'frontend_bundle'}});
             window.dispatchEvent(customEvent);
           });
 
@@ -807,13 +807,12 @@ class Crossword extends Component {
                     clueInFocus={focused}
                     crossword={this}
                 />
-                <div class="below_controls"></div>
+                <div class="crossword__container__below-controls"></div>
                 <Clues
                     clues={this.cluesData()}
                     focussed={focused}
                     setReturnPosition={this.setReturnPosition.bind(this)}
                 />
-                <div>Below Controls</div>
             </div>
         );
     }