-
Notifications
You must be signed in to change notification settings - Fork 556
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into al-update-cmp-13-8-0
- Loading branch information
Showing
2 changed files
with
10 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,4 +62,14 @@ trait JournalismSwitches { | |
sellByDate = never, | ||
exposeClientSide = false, | ||
) | ||
|
||
val Lightbox = Switch( | ||
SwitchGroup.Journalism, | ||
name = "lightbox", | ||
description = "Enable lightbox for images", | ||
owners = Seq(Owner.withEmail("[email protected]")), | ||
safeState = On, | ||
sellByDate = never, | ||
exposeClientSide = true, | ||
) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ import java.time.LocalDate | |
object ActiveExperiments extends ExperimentsDefinition { | ||
override val allExperiments: Set[Experiment] = | ||
Set( | ||
Lightbox, | ||
AdaptiveSite, | ||
DeeplyRead, | ||
) | ||
|
@@ -27,15 +26,6 @@ object DeeplyRead | |
participationGroup = Perc50, | ||
) | ||
|
||
object Lightbox | ||
extends Experiment( | ||
name = "lightbox", | ||
description = "Testing the impact lightbox might have on our CWVs", | ||
owners = Seq(Owner.withEmail("[email protected]")), | ||
sellByDate = LocalDate.of(2024, 1, 31), | ||
participationGroup = Perc5A, | ||
) | ||
|
||
// Removing while we are still implementing this content type in DCR | ||
//object DCRImageContent | ||
// extends Experiment( | ||
|