Merge branch 'main' into ei/fix-prebid-tables

guardian · Oct 22, 2024 · a936bfd · a936bfd
2 parents 37a0d36 + 8ff1c71
commit a936bfd
Show file tree

Hide file tree

Showing 7 changed files with 43 additions and 9 deletions.
diff --git a/applications/app/views/fragments/crosswords/crosswordMetaHeader.scala.html b/applications/app/views/fragments/crosswords/crosswordMetaHeader.scala.html
@@ -38,9 +38,9 @@ <h1 itemprop="headline" class="content__headline js-score">@Html(crosswordPage.i
                     <a href="https://app.adjust.com/16xt6hai" data-link-name="crossword-mobile-link">Download the Guardian app</a> for a better puzzles experience
                 </div>
 
-                <div class="hide-until-leftcol crossword__clues-header">
-                    <a href="https://app.adjust.com/16xt6hai" data-link-name="crossword-desktop-link">Download the Guardian app</a> for a better puzzles experience
+                 <div class="hide-until-leftcol crossword__clues-header">
                 </div>
+
             }
 
             <div class="meta__extras meta__extras--crossword">

diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala
@@ -47,8 +47,8 @@ trait ABTestSwitches {
 
   Switch(
     ABTests,
-    "ab-us-big-events",
-    "Test revenue impact of using shared id in prebid",
+    "ab-usa-expandable-marketing-card",
+    "Test the impact of showing the user a component that highlights the Guardians journalism",
     owners = Seq(Owner.withEmail("[email protected]")),
     safeState = Off,
     sellByDate = Some(LocalDate.of(2024, 12, 18)),

diff --git a/common/app/crosswords/CrosswordPage.scala b/common/app/crosswords/CrosswordPage.scala
@@ -63,6 +63,7 @@ class CrosswordSearchPage extends StandalonePage {
     "everyman",
     "azed",
     "weekend",
+    "special",
   )
 
   def queryParameter(crossType: String): String = {

diff --git a/common/app/navigation/NavLinks.scala b/common/app/navigation/NavLinks.scala
@@ -238,6 +238,7 @@ object NavLinks {
       NavLink("Azed", "/crosswords/series/azed"),
       NavLink("Genius", "/crosswords/series/genius"),
       NavLink("Weekend", "/crosswords/series/weekend-crossword"),
+      NavLink("Special", "/crosswords/series/special"),
     ),
   )
   val wordiply = NavLink(
@@ -742,6 +743,7 @@ object NavLinks {
     "crosswords/series/genius",
     "crosswords/series/speedy",
     "crosswords/series/everyman",
+    "crosswords/series/special",
     "crosswords/series/azed",
     "fashion/beauty",
     "technology/motoring",

diff --git a/common/test/resources/reference-navigation.json b/common/test/resources/reference-navigation.json
@@ -924,6 +924,12 @@
 						"url": "/crosswords/series/weekend-crossword",
 						"children": [],
 						"classList": []
+					},
+					{
+						"title": "Special",
+						"url": "/crosswords/series/special",
+						"children": [],
+						"classList": []
 					}
 				],
 				"classList": []
@@ -1665,6 +1671,12 @@
 						"url": "/crosswords/series/weekend-crossword",
 						"children": [],
 						"classList": []
+					},
+					{
+						"title": "Special",
+						"url": "/crosswords/series/special",
+						"children": [],
+						"classList": []
 					}
 				],
 				"classList": []
@@ -2364,6 +2376,12 @@
 						"url": "/crosswords/series/weekend-crossword",
 						"children": [],
 						"classList": []
+					},
+					{
+						"title": "Special",
+						"url": "/crosswords/series/special",
+						"children": [],
+						"classList": []
 					}
 				],
 				"classList": []
@@ -3260,6 +3278,12 @@
 						"url": "/crosswords/series/weekend-crossword",
 						"children": [],
 						"classList": []
+					},
+					{
+						"title": "Special",
+						"url": "/crosswords/series/special",
+						"children": [],
+						"classList": []
 					}
 				],
 				"classList": []
@@ -3401,6 +3425,7 @@
 		"crosswords/series/genius",
 		"crosswords/series/speedy",
 		"crosswords/series/everyman",
+		"crosswords/series/special",
 		"crosswords/series/azed",
 		"fashion/beauty",
 		"technology/motoring",
@@ -4253,6 +4278,12 @@
 						"url": "/crosswords/series/weekend-crossword",
 						"children": [],
 						"classList": []
+					},
+					{
+						"title": "Special",
+						"url": "/crosswords/series/special",
+						"children": [],
+						"classList": []
 					}
 				],
 				"classList": []

diff --git a/...rc/javascripts/projects/common/modules/experiments/tests/usa-expandable-marketing-card.js b/...rc/javascripts/projects/common/modules/experiments/tests/usa-expandable-marketing-card.js
@@ -5,8 +5,8 @@ export const UsaExpandableMarketingCard = {
 	author: '[email protected]',
 	description:
 		'Test the impact of showing the user a component that highlights the Guardians journalism.',
-	audience: 0,
-	audienceOffset: 0,
+	audience: 15 / 100,
+	audienceOffset: 0 / 100,
 	audienceCriteria: 'US-based users that see the US edition.',
 	successMeasure: 'Users are more likely to engage with the site.',
 	canRun: () => true,

diff --git a/yarn.lock b/yarn.lock
@@ -11317,8 +11317,8 @@ __metadata:
   linkType: hard
 
 "http-proxy-middleware@npm:^2.0.3":
-  version: 2.0.6
-  resolution: "http-proxy-middleware@npm:2.0.6"
+  version: 2.0.7
+  resolution: "http-proxy-middleware@npm:2.0.7"
   dependencies:
     "@types/http-proxy": "npm:^1.17.8"
     http-proxy: "npm:^1.18.1"
@@ -11330,7 +11330,7 @@ __metadata:
   peerDependenciesMeta:
     "@types/express":
       optional: true
-  checksum: 10c0/25a0e550dd1900ee5048a692e0e9b2b6339d06d487a705d90c47e359e9c6561d648cd7862d001d090e651c9efffa1b6e5160fcf1f299b5fa4935f76e9754eb11
+  checksum: 10c0/8d00a61eb215b83826460b07489d8bb095368ec16e02a9d63e228dcf7524e7c20d61561e5476de1391aecd4ec32ea093279cdc972115b311f8e0a95a24c9e47e
   languageName: node
   linkType: hard