Delete old header bidding endpoint (#27678)

guardian · Dec 19, 2024 · a3726fd · a3726fd
1 parent 0537940
commit a3726fd
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 27 deletions.
diff --git a/commercial/app/controllers/CommercialControllers.scala b/commercial/app/controllers/CommercialControllers.scala
@@ -25,7 +25,6 @@ trait CommercialControllers {
   lazy val piggybackPixelController = wire[PiggybackPixelController]
   lazy val cmpDataController = wire[CmpDataController]
   lazy val adsDotTextFileController = wire[AdsDotTextViewController]
-  lazy val prebidAnalyticsController = wire[PrebidAnalyticsController]
   lazy val passbackController = wire[PassbackController]
   lazy val ampIframeHtmlController = wire[AmpIframeHtmlController]
   lazy val nonRefreshableLineItemsController = wire[nonRefreshableLineItemsController]

diff --git a/commercial/app/controllers/PrebidAnalyticsController.scala b/commercial/app/controllers/PrebidAnalyticsController.scala
diff --git a/commercial/conf/routes b/commercial/conf/routes
@@ -41,9 +41,6 @@ GET         /commercial/cmp/shortvendorlist.json
 GET         /ads.txt                                                        commercial.controllers.AdsDotTextViewController.renderTextFile()
 GET         /app-ads.txt                                                    commercial.controllers.AdsDotTextViewController.renderAppTextFile()
 
-# Analytics
-POST        /commercial/api/hb                                              commercial.controllers.PrebidAnalyticsController.insert()
-
 # Passbacks
 GET         /commercial/ias-passback/:size                                  commercial.controllers.PassbackController.renderIasPassback(size)
 

diff --git a/common/app/common/configuration.scala b/common/app/common/configuration.scala
@@ -515,8 +515,6 @@ class GuardianConfiguration extends GuLogging {
 
     lazy val expiredPaidContentUrl = s"${site.host}/info/2015/feb/06/paid-content-removal-policy"
 
-    lazy val prebidAnalyticsStream = configuration.getMandatoryStringProperty("commercial.prebid.analytics.stream")
-
     lazy val prebidServerUrl =
       configuration.getStringProperty("commercial.prebid.server.url") getOrElse "http://localhost:8000"
 

diff --git a/common/app/http/RequestLoggingFilter.scala b/common/app/http/RequestLoggingFilter.scala
@@ -29,8 +29,8 @@ class RequestLoggingFilter(implicit val mat: Materializer, executionContext: Exe
                 case _ => ""
               }
           }
-        // don't log uncacheable /commercial/api/hb POST requests due to the volume of them
-        if (rh.method != "POST" || rh.path != "/commercial/api/hb") {
+        // don't log uncacheable POST requests due to the volume of them
+        if (rh.method != "POST") {
           requestLogger.withResponse(response).info(s"${rh.method} ${rh.uri}$additionalInfo")
         }
       case Failure(error) =>

diff --git a/dev-build/conf/routes b/dev-build/conf/routes
@@ -279,7 +279,6 @@ GET            /commercial/non-refreshable-line-items.json
 GET            /ads.txt                                                                                                          commercial.controllers.AdsDotTextViewController.renderTextFile()
 GET            /app-ads.txt                                                                                                          commercial.controllers.AdsDotTextViewController.renderAppTextFile()
 GET            /commercial/ias-passback/:size                                                                                    commercial.controllers.PassbackController.renderIasPassback(size)
-POST           /commercial/api/hb commercial.controllers.PrebidAnalyticsController.insert()
 
 # Commercial Admin
 GET         /commercial                                                                                                          controllers.admin.CommercialController.renderCommercialMenu()