Skip to content

Commit

Permalink
Merge branch 'main' of github.com:guardian/frontend into pd-applepay-…
Browse files Browse the repository at this point in the history
…merchantid-install
  • Loading branch information
jamesgorrie committed Nov 2, 2023
2 parents 70de8c7 + 730dd0f commit 85648dd
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 13 deletions.
11 changes: 0 additions & 11 deletions common/app/experiments/Experiments.scala
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ object ActiveExperiments extends ExperimentsDefinition {
override val allExperiments: Set[Experiment] =
Set(
Lightbox,
ServerSideLiveblogInlineAds,
OphanEsm,
HeaderTopBarSearchCapi,
AdaptiveSite,
Expand Down Expand Up @@ -40,16 +39,6 @@ object Lightbox
participationGroup = Perc0B,
)

object ServerSideLiveblogInlineAds
extends Experiment(
name = "server-side-liveblog-inline-ads",
description =
"Test whether we can load liveblog inline ads server-side without negative effects on user experience or revenue",
owners = Seq(Owner.withGithub("@guardian/commercial-dev")),
sellByDate = LocalDate.of(2023, 11, 1),
participationGroup = Perc0C,
)

// Removing while we are still implementing this content type in DCR
//object DCRImageContent
// extends Experiment(
Expand Down
3 changes: 2 additions & 1 deletion common/app/navigation/NavLinks.scala
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ object NavLinks {
world,
usEnvironment,
usPolitics,
ukraine,
soccer,
usBusiness,
tech,
Expand Down Expand Up @@ -663,7 +664,7 @@ object NavLinks {
"money/savings",
"money/debt",
"money/work-and-careers",
"cartoons/archive",
"tone/cartoons",
"type/cartoon",
"profile/editorial",
"au/index/contributors",
Expand Down
7 changes: 6 additions & 1 deletion common/test/resources/reference-navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,11 @@
"longTitle" : "US politics",
"children" : [ ],
"classList" : [ ]
}, {
"title" : "Ukraine",
"url" : "/world/ukraine",
"children" : [ ],
"classList" : [ ]
}, {
"title" : "Soccer",
"url" : "/soccer",
Expand Down Expand Up @@ -2705,7 +2710,7 @@
"classList" : [ ]
} ]
},
"tagPages" : [ "us-news/us-politics", "australia-news/australian-politics", "australia-news/australian-immigration-and-asylum", "australia-news/indigenous-australians", "uk/scotland", "uk/wales", "uk/northernireland", "world/europe-news", "world/americas", "world/asia", "world/africa", "world/middleeast", "business/economics", "business/banking", "business/retail", "business/stock-markets", "business/eurozone", "business/diversity-and-equality", "business/us-small-business", "environment/climate-change", "environment/climate-crisis", "environment/wildlife", "environment/energy", "environment/pollution", "money/property", "money/pensions", "money/savings", "money/debt", "money/work-and-careers", "cartoons/archive", "type/cartoon", "profile/editorial", "au/index/contributors", "index/contributors", "commentisfree/series/comment-is-free-weekly", "sport/rugby-union", "sport/cricket", "sport/tennis", "sport/cycling", "sport/golf", "sport/us-sport", "sport/horse-racing", "sport/rugbyleague", "sport/boxing", "sport/formulaone", "sport/nfl", "sport/mlb", "football/mls", "sport/nba", "sport/nhl", "sport/afl", "football/a-league", "sport/nrl", "music/classicalmusicandopera", "food", "tone/recipes", "lifeandstyle/health-and-wellbeing", "lifeandstyle/family", "lifeandstyle/home-and-garden", "lifeandstyle/love-and-sex", "au/lifeandstyle/fashion", "au/lifeandstyle/food-and-drink", "au/lifeandstyle/relationships", "au/lifeandstyle/health-and-wellbeing", "travel/uk", "travel/europe", "travel/usa", "travel/skiing", "travel/australasia", "travel/asia", "theguardian", "observer", "football/live", "football/tables", "football/competitions", "football/results", "football/fixtures", "crosswords/crossword-blog", "crosswords/series/crossword-editor-update", "crosswords/series/quick", "crosswords/series/cryptic", "crosswords/series/prize", "crosswords/series/weekend-crossword", "crosswords/series/quiptic", "crosswords/series/genius", "crosswords/series/speedy", "crosswords/series/everyman", "crosswords/series/azed", "fashion/beauty", "technology/motoring", "commentisfree/commentisfree", "education/education" ],
"tagPages" : [ "us-news/us-politics", "australia-news/australian-politics", "australia-news/australian-immigration-and-asylum", "australia-news/indigenous-australians", "uk/scotland", "uk/wales", "uk/northernireland", "world/europe-news", "world/americas", "world/asia", "world/africa", "world/middleeast", "business/economics", "business/banking", "business/retail", "business/stock-markets", "business/eurozone", "business/diversity-and-equality", "business/us-small-business", "environment/climate-change", "environment/climate-crisis", "environment/wildlife", "environment/energy", "environment/pollution", "money/property", "money/pensions", "money/savings", "money/debt", "money/work-and-careers", "tone/cartoons", "type/cartoon", "profile/editorial", "au/index/contributors", "index/contributors", "commentisfree/series/comment-is-free-weekly", "sport/rugby-union", "sport/cricket", "sport/tennis", "sport/cycling", "sport/golf", "sport/us-sport", "sport/horse-racing", "sport/rugbyleague", "sport/boxing", "sport/formulaone", "sport/nfl", "sport/mlb", "football/mls", "sport/nba", "sport/nhl", "sport/afl", "football/a-league", "sport/nrl", "music/classicalmusicandopera", "food", "tone/recipes", "lifeandstyle/health-and-wellbeing", "lifeandstyle/family", "lifeandstyle/home-and-garden", "lifeandstyle/love-and-sex", "au/lifeandstyle/fashion", "au/lifeandstyle/food-and-drink", "au/lifeandstyle/relationships", "au/lifeandstyle/health-and-wellbeing", "travel/uk", "travel/europe", "travel/usa", "travel/skiing", "travel/australasia", "travel/asia", "theguardian", "observer", "football/live", "football/tables", "football/competitions", "football/results", "football/fixtures", "crosswords/crossword-blog", "crosswords/series/crossword-editor-update", "crosswords/series/quick", "crosswords/series/cryptic", "crosswords/series/prize", "crosswords/series/weekend-crossword", "crosswords/series/quiptic", "crosswords/series/genius", "crosswords/series/speedy", "crosswords/series/everyman", "crosswords/series/azed", "fashion/beauty", "technology/motoring", "commentisfree/commentisfree", "education/education" ],
"international" : {
"newsPillar" : {
"title" : "News",
Expand Down

0 comments on commit 85648dd

Please sign in to comment.