Skip to content

Commit

Permalink
Merge pull request #26633 from guardian/doml/remove-network-fronts-ba…
Browse files Browse the repository at this point in the history
…nner-test

Remove FrontsBannerAdsDcr experiment
  • Loading branch information
domlander authored Oct 19, 2023
2 parents 4b55c06 + 7caf84b commit 5664735
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 15 deletions.
10 changes: 0 additions & 10 deletions common/app/experiments/Experiments.scala
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import java.time.LocalDate
object ActiveExperiments extends ExperimentsDefinition {
override val allExperiments: Set[Experiment] =
Set(
FrontsBannerAdsDcr,
Lightbox,
ServerSideLiveblogInlineAds,
OphanEsm,
Expand Down Expand Up @@ -51,15 +50,6 @@ object ServerSideLiveblogInlineAds
participationGroup = Perc0C,
)

object FrontsBannerAdsDcr
extends Experiment(
name = "fronts-banner-ads-dcr",
description = "Creates a new ad experience on fronts pages, replacing MPUs with banner ads",
owners = Seq(Owner.withGithub("@guardian/commercial-dev")),
sellByDate = LocalDate.of(2023, 11, 1),
participationGroup = Perc0E,
)

// Removing while we are still implementing this content type in DCR
//object DCRImageContent
// extends Experiment(
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@guardian/atom-renderer": "^2.0.0",
"@guardian/automat-modules": "^0.3.8",
"@guardian/braze-components": "^15.0.1",
"@guardian/commercial": "11.16.2",
"@guardian/commercial": "11.17.1",
"@guardian/consent-management-platform": "^13.6.1",
"@guardian/core-web-vitals": "^5.0.0",
"@guardian/identity-auth": "1.1.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1908,10 +1908,10 @@
resolved "https://registry.yarnpkg.com/@guardian/braze-components/-/braze-components-15.0.1.tgz#2c936c43e654f5ae28db254329eae1b4b5861641"
integrity sha512-XNqYE9X/4aM5vZqiZInedvEZ9niPfdqwL7SjzNF0wnVbR+YObOC6QC68M521gTPcyca6r190qtnayv4GNO0peg==

"@guardian/commercial@11.16.2":
version "11.16.2"
resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.16.2.tgz#2e093cea45e452d162d568665ff958c44b8aa435"
integrity sha512-gCxW6PoQm0+Bot9j/ALitj+mugIp6W6oS6/ntAQE0gkSUD2QGtuW1NcEF8qci7Qtr0FRTf93pfx6kLJ1f8pvWw==
"@guardian/commercial@11.17.1":
version "11.17.1"
resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.17.1.tgz#20d1995af590acf1ff5cb0422d77d50319daf241"
integrity sha512-XNkuPbpKgxYozjELlyloi0OgxCrPuwBVM+KS0VaeDypbn7SWCFt5Wt2maDGB3ss3NiwJ4YKq5/On7j5Z43yBrQ==
dependencies:
"@changesets/cli" "^2.26.2"
"@octokit/core" "^4.0.5"
Expand Down

0 comments on commit 5664735

Please sign in to comment.