Skip to content

Commit

Permalink
Merge pull request #27619 from guardian/update-subnav
Browse files Browse the repository at this point in the history
Subnav changes
  • Loading branch information
rowannekabalan authored Nov 19, 2024
2 parents 31d2e97 + a062c55 commit 3e1fa65
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 44 deletions.
12 changes: 7 additions & 5 deletions common/app/navigation/NavLinks.scala
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ object NavLinks {
val indigenousAustralia = NavLink("Indigenous Australia", "/australia-news/indigenous-australians")
val indigenousAustraliaOpinion = NavLink("Indigenous", "/commentisfree/series/indigenousx")
val usNews = NavLink("US", "/us-news", longTitle = Some("US news"))
val usElections2024 = NavLink("US elections 2024", "/us-news/us-elections-2024")
val usPolitics = NavLink("US politics", "/us-news/us-politics")

val education = {
val teachers = NavLink("Teachers", "/teacher-network")
Expand Down Expand Up @@ -279,16 +279,16 @@ object NavLinks {
iconName = Some("home"),
List(
ukNews,
usElections2024,
usPolitics,
world,
climateCrisis,
middleEast,
ukraine,
football,
newsletters,
ukBusiness,
ukEnvironment,
politics,
education,
society,
science,
tech,
Expand Down Expand Up @@ -317,9 +317,10 @@ object NavLinks {
val usNewsPillar = ukNewsPillar.copy(children =
List(
usNews,
usElections2024,
usPolitics,
world,
usEnvironment,
middleEast,
ukraine,
usSoccer,
usBusiness,
Expand All @@ -332,9 +333,10 @@ object NavLinks {
val intNewsPillar = ukNewsPillar.copy(
children = List(
world,
usElections2024,
usPolitics,
ukNews,
climateCrisis,
middleEast,
ukraine,
ukEnvironment,
science,
Expand Down
71 changes: 32 additions & 39 deletions common/test/resources/reference-navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@
"classList": []
},
{
"title": "US elections 2024",
"url": "/us-news/us-elections-2024",
"title": "US politics",
"url": "/us-news/us-politics",
"children": [],
"classList": []
},
Expand Down Expand Up @@ -163,6 +163,12 @@
"children": [],
"classList": []
},
{
"title": "Middle East",
"url": "/world/middleeast",
"children": [],
"classList": []
},
{
"title": "Ukraine",
"url": "/world/ukraine",
Expand Down Expand Up @@ -341,37 +347,6 @@
"children": [],
"classList": []
},
{
"title": "Education",
"url": "/education",
"children": [
{
"title": "Schools",
"url": "/education/schools",
"children": [],
"classList": []
},
{
"title": "Teachers",
"url": "/teacher-network",
"children": [],
"classList": []
},
{
"title": "Universities",
"url": "/education/universities",
"children": [],
"classList": []
},
{
"title": "Students",
"url": "/education/students",
"children": [],
"classList": []
}
],
"classList": []
},
{
"title": "Society",
"url": "/society",
Expand Down Expand Up @@ -1025,8 +1000,8 @@
"classList": []
},
{
"title": "US elections 2024",
"url": "/us-news/us-elections-2024",
"title": "US politics",
"url": "/us-news/us-politics",
"children": [],
"classList": []
},
Expand Down Expand Up @@ -1131,6 +1106,12 @@
],
"classList": []
},
{
"title": "Middle East",
"url": "/world/middleeast",
"children": [],
"classList": []
},
{
"title": "Ukraine",
"url": "/world/ukraine",
Expand Down Expand Up @@ -2510,8 +2491,8 @@
"classList": []
},
{
"title": "US elections 2024",
"url": "/us-news/us-elections-2024",
"title": "US politics",
"url": "/us-news/us-politics",
"children": [],
"classList": []
},
Expand Down Expand Up @@ -2602,6 +2583,12 @@
"children": [],
"classList": []
},
{
"title": "Middle East",
"url": "/world/middleeast",
"children": [],
"classList": []
},
{
"title": "Ukraine",
"url": "/world/ukraine",
Expand Down Expand Up @@ -3516,8 +3503,8 @@
"classList": []
},
{
"title": "US elections 2024",
"url": "/us-news/us-elections-2024",
"title": "US politics",
"url": "/us-news/us-politics",
"children": [],
"classList": []
},
Expand Down Expand Up @@ -3608,6 +3595,12 @@
"children": [],
"classList": []
},
{
"title": "Middle East",
"url": "/world/middleeast",
"children": [],
"classList": []
},
{
"title": "Ukraine",
"url": "/world/ukraine",
Expand Down

0 comments on commit 3e1fa65

Please sign in to comment.