Skip to content

Commit

Permalink
Remove all GA references in docs and the package
Browse files Browse the repository at this point in the history
  • Loading branch information
deedeeh committed May 30, 2024
1 parent 6917c74 commit 3e13e94
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 20 deletions.
1 change: 0 additions & 1 deletion common/app/model/content.scala
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ final case class Content(

def javascriptConfig: Map[String, JsValue] =
Map(
("contentId", JsString(metadata.id)),
("publication", JsString(publication)),
("hasShowcaseMainElement", JsBoolean(elements.hasShowcaseMainElement)),
("pageCode", JsString(internalPageCode)),
Expand Down
4 changes: 0 additions & 4 deletions common/app/model/meta.scala
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,6 @@ final case class Tags(tags: List[Tag]) {
_.id
}

lazy val commissioningDesks: List[String] = tracking.map(_.id).collect { case Tags.CommissioningDesk(desk) => desk }
lazy val blogOrSeriesTag: Option[Tag] = {
tags.find(tag => tag.showSeriesInMeta && (tag.isBlog || tag.isSeries))
}
Expand Down Expand Up @@ -904,7 +903,6 @@ final case class Tags(tags: List[Tag]) {
),
),
("blogIds", JsString(blogs.map(_.id).mkString(","))),
("commissioningDesks", JsString(commissioningDesks.mkString(","))),
)
}

Expand Down Expand Up @@ -959,8 +957,6 @@ object Tags {
"tone/reviews",
)

val CommissioningDesk: Regex = """tracking/commissioningdesk/(.*)""".r

def make(apiContent: contentapi.Content): Tags = {
Tags(apiContent.tags.toList map {
Tag.make(_)
Expand Down
3 changes: 0 additions & 3 deletions common/app/views/fragments/inlineJSNonBlocking.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@

// ************* ANALYTICS *************

// Ophan pageview ID and browser ID are needed by Google Analytics, which runs just after this script tag
@InlineJs(ophanConfig().body, "ophanConfig.js")

@if(page.metadata.contentType.exists { c =>
c == DotcomContentType.Article ||
c == DotcomContentType.LiveBlog ||
Expand Down
4 changes: 1 addition & 3 deletions docs/02-architecture/06-client-side-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,7 @@ Gets the [Ophan browserId](https://github.com/guardian/frontend/blob/main/common

### Analytics

The analytics for Dotcom are defined in [analytics/base.scala.html](https://github.com/guardian/frontend/blob/main/common/app/views/fragments/analytics/base.scala.html). It contains [Google Analytics](https://github.com/guardian/frontend/blob/main/common/app/views/fragments/analytics/google.scala.html), [Omniture](https://github.com/guardian/frontend/blob/main/common/app/views/fragments/analytics/omniture.scala.html) and [Comscore](https://github.com/guardian/frontend/blob/main/common/app/views/fragments/analytics/comscore.scala.html).

[Read more about the Google Analytics implementation](https://github.com/guardian/frontend/blob/main/docs/03-dev-howtos/14-implement-google-analytics.md).
The analytics for Dotcom are defined in [analytics/base.scala.html](https://github.com/guardian/frontend/blob/main/common/app/views/fragments/analytics/base.scala.html).

### Bootstraps

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"@guardian/source-react-components": "22.1.0",
"@guardian/source-react-components-development-kitchen": "19.0.0",
"@guardian/support-dotcom-components": "1.1.3",
"@types/google.analytics": "^0.0.42",
"@types/googletag": "^1.1.3",
"@types/jest": "29.5.12",
"@types/lodash-es": "^4.17.4",
Expand Down
8 changes: 0 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2805,7 +2805,6 @@ __metadata:
"@guardian/source-react-components": "npm:22.1.0"
"@guardian/source-react-components-development-kitchen": "npm:19.0.0"
"@guardian/support-dotcom-components": "npm:1.1.3"
"@types/google.analytics": "npm:^0.0.42"
"@types/googletag": "npm:^1.1.3"
"@types/jest": "npm:29.5.12"
"@types/lodash-es": "npm:^4.17.4"
Expand Down Expand Up @@ -4334,13 +4333,6 @@ __metadata:
languageName: node
linkType: hard

"@types/google.analytics@npm:^0.0.42":
version: 0.0.42
resolution: "@types/google.analytics@npm:0.0.42"
checksum: 10c0/7145854f12370c87547a26756e32520b019905e785d0b713ba316481e1c44bfee209fbf2f0956dc86c6531f468cb13adb71bf8117634ac401c12c5b36026c5dd
languageName: node
linkType: hard

"@types/googletag@npm:^1.1.3":
version: 1.2.3
resolution: "@types/googletag@npm:1.2.3"
Expand Down

0 comments on commit 3e13e94

Please sign in to comment.