Skip to content

Commit

Permalink
Make requested changes to the subnav (#27412)
Browse files Browse the repository at this point in the history
- Remove Olympics 2024 from the main subnav
- Remove Olympics 2024 from the US sport front subnav
- Add Democratic national convention to the main subnav
  • Loading branch information
JamieB-gu authored Aug 14, 2024
1 parent 98643ab commit 2bba82b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 14 deletions.
6 changes: 4 additions & 2 deletions common/app/navigation/NavLinks.scala
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ object NavLinks {

val auBusiness = ukBusiness.copy(children = List(markets, money, projectSyndicate, retail))

val democraticNationalConvention =
NavLink("Democratic national convention", "/us-news/democratic-national-convention-2024")

/* OPINION */
val columnists = NavLink("Columnists", "/index/contributors")
val auColumnists = NavLink("Columnists", "/au/index/contributors")
Expand Down Expand Up @@ -313,10 +316,10 @@ object NavLinks {
List(
usNews,
usElections2024,
democraticNationalConvention,
world,
usEnvironment,
ukraine,
olympics2024,
usSoccer,
usBusiness,
usTech,
Expand Down Expand Up @@ -420,7 +423,6 @@ object NavLinks {
)
val usSportPillar = ukSportPillar.copy(
children = List(
olympics2024,
usSoccer,
NFL,
tennis,
Expand Down
18 changes: 6 additions & 12 deletions common/test/resources/reference-navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,12 @@
"children": [],
"classList": []
},
{
"title": "Democratic national convention",
"url": "/us-news/democratic-national-convention-2024",
"children": [],
"classList": []
},
{
"title": "World",
"url": "/world",
Expand Down Expand Up @@ -1125,12 +1131,6 @@
"children": [],
"classList": []
},
{
"title": "Olympics 2024",
"url": "/sport/olympic-games-2024",
"children": [],
"classList": []
},
{
"title": "Soccer",
"url": "/us/soccer",
Expand Down Expand Up @@ -1283,12 +1283,6 @@
"longTitle": "Sport home",
"iconName": "home",
"children": [
{
"title": "Olympics 2024",
"url": "/sport/olympic-games-2024",
"children": [],
"classList": []
},
{
"title": "Soccer",
"url": "/us/soccer",
Expand Down

0 comments on commit 2bba82b

Please sign in to comment.