Skip to content

Commit

Permalink
Merge branch 'main' into dark-mode-switch
Browse files Browse the repository at this point in the history
  • Loading branch information
cemms1 authored Oct 19, 2023
2 parents aee55b5 + b6be51d commit 1c9ccbd
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 30 deletions.
20 changes: 0 additions & 20 deletions common/app/conf/switches/FeatureSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -522,26 +522,6 @@ trait FeatureSwitches {
exposeClientSide = true,
)

val VerticalVideo = Switch(
SwitchGroup.Feature,
"vertical-video",
"When ON, shows the vertical video container",
owners = Seq(Owner.withGithub("@guardian/editorial-experience")),
safeState = Off,
sellByDate = never,
exposeClientSide = true,
)

val VerticalVideoSurvey = Switch(
SwitchGroup.Feature,
"vertical-video-survey",
"When ON, shows the vertical video survey link",
owners = Seq(Owner.withGithub("@guardian/editorial-experience")),
safeState = Off,
sellByDate = never,
exposeClientSide = true,
)

val DarkModeInApps = Switch(
SwitchGroup.Feature,
"dark-mode-apps",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
@import views.html.fragments.containers.facia_cards._
@import views.support.Commercial.container.shouldRenderAsPaidContainer
@import views.support.GetClasses
@import conf.switches.Switches.{MostViewedFronts, VerticalVideo => VerticalVideoSwitch}
@import conf.switches.Switches.{MostViewedFronts}
@import experiments.ActiveExperiments

@import conf.audio.FlagshipFrontContainer
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
@import model.VideoFaciaProperties
@import layout.FaciaCardHeader
@import model.Pillar.RichPillar
@import conf.switches.Switches.{VerticalVideoSurvey}

@(containerDefinition: layout.FaciaContainer, frontProperties: model.FrontProperties)(implicit requestHeader: RequestHeader)

Expand Down Expand Up @@ -116,12 +115,4 @@ <h2 class="video-title fc-container__header__title">
@fragments.inlineSvg("chevron-right", "icon", Seq("vertical-video-playlist__icon", "vertical-video-playlist__icon--next"))
</a>
</div>
@if(VerticalVideoSurvey.isSwitchedOn) {
<div class="vertical-video__ext-link">
We're experimenting with vertical video.&nbsp;
<a href="https://guardiannewsandmedia.formstack.com/forms/vertical_video"
target="_blank"
rel="noopener noreferrer">Tell us what you think</a>
</div>
}
</div>

0 comments on commit 1c9ccbd

Please sign in to comment.