Skip to content

Commit

Permalink
Attempt to exclude deps with com.typesafe.play from `play-json-exte…
Browse files Browse the repository at this point in the history
…nsion`

`ai.x:play-json-extension:0.42.0` has not been updated yet to use the new `org.playframework` groupId. Tried to use the workaround suggested here bizzabo/play-json-extensions#94 but was unsuccessful.
  • Loading branch information
ioannakok committed Dec 12, 2023
1 parent cde9a28 commit 1c1306e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ val common = library("common")
pekkoSlf4j,
),
TestAssets / mappings ~= filterAssets,
// excludeDependencies ++= Seq(
// // As of Play 3.0, groupId has changed to org.playframework; exclude transitive dependencies to the old artifacts
// ExclusionRule(organization = "com.typesafe.play")
// ),
)

val commonWithTests = withTests(common)
Expand Down
4 changes: 3 additions & 1 deletion project/Dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ object Dependencies {
val enumeratumPlayJson = "com.beachape" %% "enumeratum-play-json" % "1.8.0"
val commercialShared = "com.gu" %% "commercial-shared" % "6.1.8"
val playJson = "org.playframework" %% "play-json" % playJsonVersion
val playJsonExtensions = "ai.x" %% "play-json-extensions" % playJsonExtensionsVersion
val playJsonExtensions = ("ai.x" %% "play-json-extensions" % playJsonExtensionsVersion)
// .excludeAll(ExclusionRule(organization = "com.typesafe.play"))
// .excludeAll(ExclusionRule(organization = "com.typesafe.play"))
val playJsonJoda = "org.playframework" %% "play-json-joda" % playJsonVersion
val atomRenderer = ("com.gu" %% "atom-renderer" % "1.2.0")
.excludeAll(ExclusionRule("com.typesafe.play", "twirl-api_2.13"))
Expand Down

0 comments on commit 1c1306e

Please sign in to comment.