Remove unused parameter from method

guardian · May 15, 2024 · 17fd0a5 · 17fd0a5
1 parent c917e22
commit 17fd0a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/article/app/pages/StoryHtmlPage.scala b/article/app/pages/StoryHtmlPage.scala
@@ -32,7 +32,7 @@ object StoryHtmlPage {
     if (pageWithStoryPackage.item.tags.isLiveBlog) {
       Html(s"<script>window.guardian.config.page.dcrCouldRender = true</script>")
     } else {
-      val thisDcrCouldRender: Boolean = dcrChecks(pageWithStoryPackage, request).values.forall(identity)
+      val thisDcrCouldRender: Boolean = dcrChecks(pageWithStoryPackage).values.forall(identity)
       Html(s"<script>window.guardian.config.page.dcrCouldRender = $thisDcrCouldRender</script>")
     }
   }

diff --git a/article/app/services/dotcomrendering/ArticlePicker.scala b/article/app/services/dotcomrendering/ArticlePicker.scala
@@ -23,15 +23,15 @@ object ArticlePageChecks {
 
 object ArticlePicker {
 
-  def dcrChecks(page: PageWithStoryPackage, request: RequestHeader): Map[String, Boolean] = {
+  def dcrChecks(page: PageWithStoryPackage): Map[String, Boolean] = {
     Map(
       ("isSupportedType", ArticlePageChecks.isSupportedType(page)),
       ("isNotAGallery", ArticlePageChecks.isNotAGallery(page)),
     )
   }
 
-  private[this] def dcrArticle100PercentPage(page: PageWithStoryPackage, request: RequestHeader): Boolean = {
-    val allowListFeatures = dcrChecks(page, request)
+  private[this] def dcrArticle100PercentPage(page: PageWithStoryPackage): Boolean = {
+    val allowListFeatures = dcrChecks(page)
     val article100PercentPageFeatures = allowListFeatures.view.filterKeys(
       Set(
         "isSupportedType",
@@ -45,14 +45,14 @@ object ArticlePicker {
   def getTier(page: PageWithStoryPackage, path: String)(implicit
       request: RequestHeader,
   ): RenderType = {
-    val checks = dcrChecks(page, request)
+    val checks = dcrChecks(page)
     val dcrCanRender = checks.values.forall(identity)
     val isNotPaidContent = ArticlePageChecks.isNotPaidContent(page)
     val shouldServePressed = PressedContent.isPressed(ensureStartingForwardSlash(path)) && isNotPaidContent
 
     val tier: RenderType = decideTier(shouldServePressed, dcrCanRender)
 
-    val isArticle100PercentPage = dcrArticle100PercentPage(page, request);
+    val isArticle100PercentPage = dcrArticle100PercentPage(page)
     val pageTones = page.article.tags.tones.map(_.id).mkString(", ")
 
     // include features that we wish to log but not allow-list against