Merge pull request #26693 from guardian/sa-delete-merch-ab-test

Remove ads-in-merch ab test

common/app/conf/switches/ABTestSwitches.scala

@@ -55,16 +55,6 @@ trait ABTestSwitches {
     exposeClientSide = true,
   )
 
-  Switch(
-    ABTests,
-    "ab-ads-in-merch",
-    "Test the commercial impact of showing adverts in merchandising-high and merchandising slots",
-    owners = Seq(Owner.withEmail("[email protected]")),
-    safeState = Off,
-    sellByDate = Some(LocalDate.of(2023, 11, 30)),
-    exposeClientSide = true,
-  )
-
   Switch(
     ABTests,
     "ab-elements-manager",

common/app/conf/switches/CommercialSwitches.scala

@@ -1,5 +1,6 @@
 package conf.switches
 
+import java.time.LocalDate
 import conf.switches.Expiry.never
 import conf.switches.Owner.group
 import conf.switches.SwitchGroup.{Commercial, CommercialPrebid, Membership}
@@ -431,4 +432,14 @@ trait PrebidSwitches {
     sellByDate = never,
     exposeClientSide = true,
   )
+
+  val adsInMerch: Switch = Switch(
+    group = Commercial,
+    name = "ads-in-merch",
+    description = "Enable showing adverts in merchandising-high and merchandising slots",
+    owners = group(Commercial),
+    safeState = Off,
+    sellByDate = Some(LocalDate.of(2023, 12, 4)),
+    exposeClientSide = true,
+  )
 }

package.json

@@ -18,7 +18,7 @@
 		"@guardian/atom-renderer": "^2.0.0",
 		"@guardian/automat-modules": "^0.3.8",
 		"@guardian/braze-components": "^15.0.1",
-		"@guardian/commercial": "11.22.0",
+		"@guardian/commercial": "11.23.0",
 		"@guardian/consent-management-platform": "13.7.1",
 		"@guardian/core-web-vitals": "^5.0.0",
 		"@guardian/identity-auth": "1.1.0",

static/src/javascripts/projects/common/modules/analytics/shouldCaptureMetrics.ts

@@ -1,13 +1,11 @@
 import type { ABTest } from '@guardian/ab-core';
 import { getUrlVars } from 'lib/url';
 import { isInABTestSynchronous } from '../experiments/ab';
-import { adsInMerch } from '../experiments/tests/ads-in-merch';
 import { integrateIma } from '../experiments/tests/integrate-ima';
 
 const defaultClientSideTests: ABTest[] = [
 	/* linter, please keep this array multi-line */
 	integrateIma,
-	adsInMerch,
 ];
 
 /**

static/src/javascripts/projects/common/modules/experiments/ab-tests.ts

@@ -1,5 +1,4 @@
 import type { ABTest } from '@guardian/ab-core';
-import { adsInMerch } from './tests/ads-in-merch';
 import { consentlessAds } from './tests/consentlessAds';
 import { deeplyReadArticleFooterTest } from './tests/deeply-read-article-footer';
 import { elementsManager } from './tests/elements-manager';
@@ -18,7 +17,6 @@ export const concurrentTests: readonly ABTest[] = [
 	deeplyReadArticleFooterTest,
 	consentlessAds,
 	integrateIma,
-	adsInMerch,
 	elementsManager,
 	prebidKargo,
 ];

yarn.lock

@@ -2350,10 +2350,10 @@
   resolved "https://registry.yarnpkg.com/@guardian/braze-components/-/braze-components-15.0.1.tgz#2c936c43e654f5ae28db254329eae1b4b5861641"
   integrity sha512-XNqYE9X/4aM5vZqiZInedvEZ9niPfdqwL7SjzNF0wnVbR+YObOC6QC68M521gTPcyca6r190qtnayv4GNO0peg==
 
-"@guardian/commercial@11.22.0":
-  version "11.22.0"
-  resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.22.0.tgz#e9d6e168a08f3c02cc4050c4390bf571f26803e4"
-  integrity sha512-i9CUCtZTjfErKKgHFJ2jdJg/JqBO0mX8TQHBNQvhN7xN+68kQEFCTam26KDMY1d2OP/ZWVOjSFCYySXHB4+u/w==
+"@guardian/commercial@11.23.0":
+  version "11.23.0"
+  resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-11.23.0.tgz#4d96fbf72615d1f0bff4c6fff5211b78f9425a1d"
+  integrity sha512-qlPZVYQarG1FW9JitttX/REIKpaPAQ4ZMt4pwSXLQYE/8WQ7l3O/Qt1WX8BacFU7EcdElr13Svb3KIA4vVK8DA==
   dependencies:
     "@changesets/cli" "^2.26.2"
     "@octokit/core" "^4.0.5"