Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into jlk/commercial-bundle…
Browse files Browse the repository at this point in the history
…-fetcher
  • Loading branch information
Jakeii committed Dec 3, 2024
2 parents bf53fff + d26c066 commit 0361b2e
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 48 deletions.
12 changes: 1 addition & 11 deletions common/app/conf/switches/ABTestSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ trait ABTestSwitches {
"Test the Opt Out frequency capping feature",
owners = Seq(Owner.withEmail("[email protected]")),
safeState = Off,
sellByDate = Some(LocalDate.of(2024, 12, 2)),
sellByDate = Some(LocalDate.of(2025, 1, 29)),
exposeClientSide = true,
highImpact = false,
)
Expand All @@ -71,16 +71,6 @@ trait ABTestSwitches {
highImpact = false,
)

Switch(
ABTests,
"ab-new-header-bidding-endpoint",
"Test new header bidding (prebid) analytics endpoint",
owners = Seq(Owner.withEmail("[email protected]")),
safeState = Off,
sellByDate = Some(LocalDate.of(2024, 12, 2)),
exposeClientSide = true,
highImpact = false,
)
Switch(
ABTests,
"ab-gpid-prebid-ad-units",
Expand Down
4 changes: 2 additions & 2 deletions common/app/conf/switches/FeatureSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -567,9 +567,9 @@ trait FeatureSwitches {
group = SwitchGroup.Feature,
name = "disable-front-container-show-hide",
description = "For users with no currently hidden containers on a front, removes the ability to hide containers",
owners = Seq(Owner.withGithub("cemms1")),
owners = Seq(Owner.withEmail("[email protected]")),
safeState = On,
sellByDate = LocalDate.of(2024, 11, 29),
sellByDate = LocalDate.of(2025, 2, 4),
exposeClientSide = true,
highImpact = false,
)
Expand Down
3 changes: 2 additions & 1 deletion common/app/navigation/NavLinks.scala
Original file line number Diff line number Diff line change
Expand Up @@ -319,11 +319,12 @@ object NavLinks {
usNews,
usPolitics,
world,
usEnvironment,
climateCrisis,
middleEast,
ukraine,
usSoccer,
usBusiness,
usEnvironment,
usTech,
science,
newsletters,
Expand Down
74 changes: 40 additions & 34 deletions common/test/resources/reference-navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -1070,40 +1070,9 @@
"classList": []
},
{
"title": "Environment",
"url": "/us/environment",
"children": [
{
"title": "Climate crisis",
"url": "/environment/climate-crisis",
"children": [],
"classList": []
},
{
"title": "Wildlife",
"url": "/environment/wildlife",
"children": [],
"classList": []
},
{
"title": "Energy",
"url": "/environment/energy",
"children": [],
"classList": []
},
{
"title": "Pollution",
"url": "/environment/pollution",
"children": [],
"classList": []
},
{
"title": "Green light",
"url": "/environment/series/green-light",
"children": [],
"classList": []
}
],
"title": "Climate crisis",
"url": "/environment/climate-crisis",
"children": [],
"classList": []
},
{
Expand Down Expand Up @@ -1198,6 +1167,43 @@
],
"classList": []
},
{
"title": "Environment",
"url": "/us/environment",
"children": [
{
"title": "Climate crisis",
"url": "/environment/climate-crisis",
"children": [],
"classList": []
},
{
"title": "Wildlife",
"url": "/environment/wildlife",
"children": [],
"classList": []
},
{
"title": "Energy",
"url": "/environment/energy",
"children": [],
"classList": []
},
{
"title": "Pollution",
"url": "/environment/pollution",
"children": [],
"classList": []
},
{
"title": "Green light",
"url": "/environment/series/green-light",
"children": [],
"classList": []
}
],
"classList": []
},
{
"title": "Tech",
"url": "/us/technology",
Expand Down

0 comments on commit 0361b2e

Please sign in to comment.