-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Cards: Enable pills in beta containers #13107
Open
jamesmockett
wants to merge
8
commits into
main
Choose a base branch
from
jm/media-card-pills
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+88
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: +772 B (+0.09%) Total Size: 892 kB
ℹ️ View Unchanged
|
jamesmockett
force-pushed
the
jm/media-card-pills
branch
from
January 8, 2025 15:45
252b848
to
7f20356
Compare
jamesmockett
force-pushed
the
jm/media-card-pills
branch
from
January 8, 2025 15:47
7f20356
to
b8fe14b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates media cards to show gallery count and podcast duration pills in beta containers only. The pill appears below the headline and trail text in place of the existing card metadata.
NB. Podcast duration is not currently populated and will be added in a subsequent PR (#13102)
Why?
This is an incremental change which forms part of a larger body of work to update the design of media cards. Following some additional design updates the intention is to enable these in all containers, replacing the existing media icons and card metadata completely.
Why?
Screenshots