-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the action required cookie #13097
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: -62 B (-0.01%) Total Size: 930 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note - I think Identity & Trust would be interested if we are removing cookies. This is so they can update their list of known cookies and if required update the cookie list in the privacy settings.
Yes I've kept a list of all the cookies we're removing and I'll make sure the CMP is updated once I'm done 👍 |
6930223
to
ca40452
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Seen on PROD (merged by @rupertbates 7 minutes and 34 seconds ago) Please check your changes! |
What does this change?
This PR removes the code which stores the value of the
alertAvailableFor
field which is returned from members-data-api.Why?
The value is not used anywhere so this simplifies the code base, removes another unused cookie and potentially allow us to stop generating this value in mdapi which will improve performance.
Screenshots