-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use square podcast image #13028
Closed
Closed
Use square podcast image #13028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -853 B (-0.09%) Total Size: 941 kB
ℹ️ View Unchanged
|
abeddow91
force-pushed
the
ab/podcast-image
branch
from
December 19, 2024 09:35
dbab173
to
2989b14
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 19, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Dec 19, 2024
Closing as this will be broken into smaller prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates podcasts cards to use the series image. Depending on the layout of the card, the podcast image appears either instead of the trail image or alongside the trail image as an accent series image above the kicker.
It also checks is the card is a media card and sets the image layout to 'top' if so, as new designs specify media card images are always top.
This currently only affects beta containers.
Why?
This is part of the redesign of media cards as part of the fairground project.
Screenshots