Mini profiles tweaks #12919
Open
Mini profiles tweaks #12919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Size Change: 0 B Total Size: 958 kB ℹ️ View Unchanged
|
simonbyford
force-pushed
the
mini-profiles-tweaks
branch
from
6691aba
to
4dd15c8
Compare
simonbyford
force-pushed
the
mini-profiles-tweaks
branch
from
4dd15c8
to
0b0ccb4
Compare
github-actions
bot
removed
the
run_chromatic
Fweddi
reviewed
Nov 29, 2024
| @@ -490,6 +492,7 @@ export const renderElement = ({ | |||
| editionId={editionId} | |||
| RenderArticleElement={RenderArticleElement} | |||
| isLastElement={index === totalElements - 1} | |||
| sectioned={!!isSectionedMiniProfilesArticle} | |||
There was a problem hiding this comment.
Does isSectionedMiniProfilesArticle need to be coerced to a boolean if it's already a boolean?
There was a problem hiding this comment.
Ah, it's optional. So it could be undefined.
Fweddi
reviewed
Nov 29, 2024
| @@ -204,3 +205,16 @@ export const WithSeparatorLine = { | |||
| }, | |||
| decorators: [centreColumnDecorator], | |||
| } satisfies Story; | |||
|
|
|||
| export const Sectioned = { | |||
There was a problem hiding this comment.
Might just be me, but sectioned as a term is unclear to me. Does it mean it's in a section?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Three separate tweaks to the mini profiles format:
h3s (with font size24px) for mini profiles articles which include sections. Continue to render titles ash2s for mini profiles articles which don't include sections. This should help distinguish titles from section headers. More info here (see "Option 2").<p></p>was considered non-empty.Why?
This was in response to feedback from Rich and Theresa
Screenshots