Migrate header files from support-dotcom-components
#11290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
force-pushed
the
migrate-header-from-sdc
branch
2 times, most recently
from
35b618c to
5d44493
Compare
|
Size Change: +15 B (0%) Total Size: 794 kB
ℹ️ View Unchanged
|
cemms1
force-pushed
the
migrate-header-from-sdc
branch
from
48e7a0c to
2413454
Compare
cemms1
force-pushed
the
migrate-header-from-sdc
branch
from
5bce21f to
5a78767
Compare
tomrf1
reviewed
May 9, 2024
dotcom-rendering/src/components/marketing/header/HeaderWrapper.tsx
Outdated
Show resolved
Hide resolved
cemms1
force-pushed
the
migrate-header-from-sdc
branch
from
3499f11 to
5fa9462
Compare
cemms1
force-pushed
the
migrate-header-from-sdc
branch
from
5fa9462 to
8fb4e25
Compare
github-actions
bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
tomrf1
approved these changes
May 15, 2024
mxdvl
reviewed
May 15, 2024
Comment on lines
+212
to
+216
| const dotCss = [dotStyles, fadeable]; | ||
|
|
||
| if (dotVisible) { | ||
| dotCss.push(visible); | ||
| } |
There was a problem hiding this comment.
FYI – falsy values will automatically be ignored by Emotion
const dotCss = [
dotStyles,
fadeable,
dotVisible ? visible : undefined
];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Requires guardian/support-dotcom-components#1123 to be merged
What does this change?
Inspired by #9959, this PR migrates code for
Headerfromsupport-dotcom-componentsto DCR.It does not change the designs for this component and is purely a migration from one repo to another. This component is not used anywhere (yet).
Why?
We are making changes to the header and top bar, and will be trialling moving the support messaging and call to action to the top bar instead of the header (#11393).
While we test this, we will use the DCR version of the
Headercomponent and after the AB test (if successful) we will permanently use the DCR version and remove the equivalent component insupport-dotcom-componentsHeadersupport component in SDCHeadersupport component in SDC (control for AB test)TopBarsupport component in DCR (variant in AB test)