Skip to content

Commit

Permalink
Remove double negation
Browse files Browse the repository at this point in the history
  • Loading branch information
abeddow91 committed Jan 8, 2025
1 parent 7775d22 commit dec12ff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export const HighlightsCard = ({
/>
</div>

{!!starRating ? (
{starRating ? (

Check failure on line 189 in dotcom-rendering/src/components/Masthead/HighlightsCard.tsx

View workflow job for this annotation

GitHub Actions / lint / check

Unexpected nullable number value in conditional. Please handle the nullish/zero/NaN cases explicitly
<div css={starWrapper}>
<StarRating rating={starRating} size="small" />
</div>
Expand Down
8 changes: 4 additions & 4 deletions dotcom-rendering/src/layouts/FrontLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export const FrontLayout = ({ front, NAV }: Props) => {

const contributionsServiceUrl = getContributionsServiceUrl(front);

const { abTests, isPreview } = front.config;
// const { abTests, isPreview } = front.config;

const { absoluteServerTimes = false } = front.config.switches;

Expand All @@ -194,9 +194,9 @@ export const FrontLayout = ({ front, NAV }: Props) => {
};

const Highlights = () => {
const showHighlights =
// Must be opted into the Europe beta test or in preview
abTests.europeBetaFrontVariant === 'variant' || isPreview;
const showHighlights = true;
// Must be opted into the Europe beta test or in preview
// abTests.europeBetaFrontVariant === 'variant' || isPreview;

const highlightsCollection =
front.pressedPage.collections.find(isHighlights);
Expand Down

0 comments on commit dec12ff

Please sign in to comment.