Skip to content

Commit

Permalink
Add kicker image option to flex special and general
Browse files Browse the repository at this point in the history
  • Loading branch information
abeddow91 committed Jan 6, 2025
1 parent 4e1c140 commit a1a8004
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 6 additions & 1 deletion dotcom-rendering/src/components/FlexibleGeneral.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ArticleDesign } from 'src/lib/articleFormat';

Check failure on line 1 in dotcom-rendering/src/components/FlexibleGeneral.tsx

View workflow job for this annotation

GitHub Actions / lint / check

'src/lib/articleFormat' import is restricted from being used by a pattern. Paths starting with “src/” are forbidden. Please use a relative path instead
import { isMediaCard } from '../lib/cardHelpers';
import { palette } from '../palette';
import type { BoostLevel } from '../types/content';
Expand Down Expand Up @@ -224,6 +225,7 @@ export const SplashCardLayout = ({
showTopBarMobile={true}
trailTextSize={trailTextSize}
canPlayInline={true}
showKickerImage={card.format.design === ArticleDesign.Audio}
/>
</LI>
</UL>
Expand Down Expand Up @@ -336,6 +338,7 @@ export const BoostedCardLayout = ({
showTopBarMobile={true}
liveUpdatesPosition={liveUpdatesPosition}
canPlayInline={true}
showKickerImage={card.format.design === ArticleDesign.Audio}
/>
</LI>
</UL>
Expand Down Expand Up @@ -403,7 +406,9 @@ export const StandardCardLayout = ({
)}
supportingContentAlignment="vertical"
supportingContentPosition="outer"
imageSize={'medium'}
imageSize={
isMediaCard(card.format) ? 'small' : 'medium'
}
aspectRatio={aspectRatio}
kickerText={card.kickerText}
showLivePlayable={false}
Expand Down
2 changes: 2 additions & 0 deletions dotcom-rendering/src/components/FlexibleSpecial.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ArticleDesign } from 'src/lib/articleFormat';

Check failure on line 1 in dotcom-rendering/src/components/FlexibleSpecial.tsx

View workflow job for this annotation

GitHub Actions / lint / check

'src/lib/articleFormat' import is restricted from being used by a pattern. Paths starting with “src/” are forbidden. Please use a relative path instead
import { isMediaCard } from '../lib/cardHelpers';
import type { BoostLevel } from '../types/content';
import type {
Expand Down Expand Up @@ -167,6 +168,7 @@ export const OneCardLayout = ({
showTopBarMobile={true}
trailTextSize={trailTextSize}
canPlayInline={true}
showKickerImage={card.format.design === ArticleDesign.Audio}
/>
</LI>
</UL>
Expand Down

0 comments on commit a1a8004

Please sign in to comment.