Skip to content

Commit

Permalink
Add new colour --multi-byline-non-linked-text
Browse files Browse the repository at this point in the history
  • Loading branch information
simonbyford committed Dec 11, 2024
1 parent 35b4e8b commit 1ae0d2e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
5 changes: 2 additions & 3 deletions dotcom-rendering/src/components/MultiByline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
headlineLightItalic34,
headlineMediumItalic24,
headlineMediumItalic28,
neutral,
space,
textSansItalic24,
textSansItalic28,
Expand Down Expand Up @@ -140,7 +139,7 @@ const bylineStyles = (format: ArticleFormat) => css`
font-style: italic;
margin-top: -4px;
font-weight: 300;
color: ${neutral[46]};
color: ${palette('--multi-byline-non-linked-text')};
a {
${subheadingStyles(format)}
color: ${palette('--link-kicker-text')};
Expand All @@ -152,7 +151,7 @@ const bylineStyles = (format: ArticleFormat) => css`
}
span[data-contributor-rel='author'] {
${subheadingStyles(format)}
color: ${neutral[46]};
color: ${palette('--multi-byline-non-linked-text')};
font-style: normal;
}
`;
Expand Down
7 changes: 7 additions & 0 deletions dotcom-rendering/src/paletteDeclarations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5376,6 +5376,9 @@ const lastUpdatedTextDark: PaletteFunction = ({ theme, design }) => {

const bioLinkUnderline: PaletteFunction = () => sourcePalette.neutral[86];

const multiBylineNonLinkedTextLight: PaletteFunction = () => sourcePalette.neutral[46];
const multiBylineNonLinkedTextDark: PaletteFunction = () => sourcePalette.neutral[60];

const bioTextSubduedLight: PaletteFunction = () => sourcePalette.neutral[46];
const bioTextSubduedDark: PaletteFunction = () => sourcePalette.neutral[86];

Expand Down Expand Up @@ -6682,6 +6685,10 @@ const paletteColours = {
light: mostViewedTabBorderLight,
dark: mostViewedTabBorderDark,
},
'--multi-byline-non-linked-text': {
light: multiBylineNonLinkedTextLight,
dark: multiBylineNonLinkedTextDark,
},
'--nav-reader-revenue-link-text': {
light: navReaderRevenueLinkText,
dark: navReaderRevenueLinkText,
Expand Down

0 comments on commit 1ae0d2e

Please sign in to comment.