Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords to pbjsConfig if user is in the prebidKeywords test #1742

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented Jan 14, 2025

What does this change?

Adds page keywords to the Prebid config following the docs here.

The change has been added behind a 50% test so that we can measure any impact this may have on revenue. I've offset the test to make sure that it doesn't overlap with the RegionSpecificPrebid test.

Why?

We want to try adding keywords to our Prebid config to help make sure programmatic ads can target our pages properly. Our current implementation for adding keywords for Magnite is out of date for our current Prebid version, so we need to update how we do this.

Once the test is complete, if we want to go ahead with adding keywords this way, we can remove the current keyword implementation for Magnite.

Screenshots

Not in the test

Screenshot 2025-01-15 at 10 48 15

In the test

Screenshot 2025-01-15 at 10 51 16

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 7fef6c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4364ms to load.
For consentless, top-above-nav took on average 2907ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@emma-imber emma-imber marked this pull request as ready for review January 15, 2025 10:54
@emma-imber emma-imber requested a review from a team as a code owner January 15, 2025 10:54
@emma-imber emma-imber merged commit 758d47c into main Jan 15, 2025
14 checks passed
@emma-imber emma-imber deleted the ei/prebid-keywords branch January 15, 2025 14:15
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @emma-imber 3 minutes and 22 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants