Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ad speed benchmarking #1741

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix ad speed benchmarking #1741

merged 1 commit into from
Jan 14, 2025

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Jan 14, 2025

What does this change?

This broke when changing to riff-raff deployment as the prod bundle build location has moved.

@Jakeii Jakeii requested a review from a team as a code owner January 14, 2025 12:48
Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: d49ef4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Jakeii Jakeii force-pushed the jlk/fix-ad-speed-test branch from 25e6dae to d49ef4a Compare January 14, 2025 12:49
Copy link
Contributor

Ad load time test results

For consented, top-above-nav took on average 4238ms to load.
For consentless, top-above-nav took on average 3093ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

@Jakeii Jakeii merged commit e18c29a into main Jan 14, 2025
14 checks passed
@Jakeii Jakeii deleted the jlk/fix-ad-speed-test branch January 14, 2025 14:31
@prout-bot
Copy link
Collaborator

Overdue on PROD (merged by @Jakeii 10 minutes and 5 seconds ago) What's gone wrong?

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @Jakeii 35 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants