Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds 10 more articles to be tested for ad load speed. Also round the final figure we show for load time to avoid long recurring decimals being outputted.
Why?
Adding a few more articles should improve the reliability of the testing but it doesn't speed it up dramatically - it still runs in less than 3 minutes. Looping through the articles we already had slowed things down a lot more. Plus I think having a wider variety of articles let's us balance out differences between them to be more representative of what's on the site.
Reliability
I've run the check using 30 articles 12 times. These are the consented results I saw:
4474
4486
4488
4488
4494
4500
4502
4506
4570
4659
4698
5453
The median value is 4501 ms and the interquartile range is 126.5
There's one big outlier of 5453 ms, but otherwise the results weren't miles away from each other