Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redplanet #1405

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Delete redplanet #1405

merged 2 commits into from
Jun 10, 2024

Conversation

emma-imber
Copy link
Contributor

@emma-imber emma-imber commented Jun 5, 2024

What does this change?

Deletes all files related to the running of redplanet - this includes launchpad, which is used by the redplanet code.

There will also be PRs needed to delete the switch in frontend, and references to the switch in dotcom-rendering. We can also look to remove redplanet from the vendor list when these code changes have been made.

Why?

We have permission to remove redplanet from the site.

Ad load speed impact

Results on this PR are about 300ms quicker for consented.

@emma-imber emma-imber requested a review from a team as a code owner June 5, 2024 16:53
Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: faf9f66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/commercial Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Ad load time test results

For consented, top-above-nav took on average 4704ms to load.
For consentless, top-above-nav took on average 2930ms to load.

Test conditions:

  • 5mbps download speed
  • 1.5mbps upload speed
  • 150ms latency

Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹Big if ad load results are to be trusted, seems to be all over the place! in the changeset PR its 4400 🤔#1398 (comment)

@emma-imber
Copy link
Contributor Author

🧹Big if ad load results are to be trusted, seems to be all over the place! in the changeset PR its 4400 🤔#1398 (comment)

Yeah there seems to be roughly 200-400ms variability between runs. I guess this PR is still a little quicker than the changeset one! Would be good to have a think about how we could make the testing a little more reliable

@emma-imber emma-imber added the [beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR label Jun 10, 2024
Copy link
Contributor

🚀 0.0.0-beta-20240610112701 published to npm as a beta release

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the smell of freshly deleted code in the morning ✨

@emma-imber emma-imber force-pushed the ei/delete-redplanet branch from b34a824 to faf9f66 Compare June 10, 2024 16:12
@emma-imber emma-imber merged commit 00497c5 into main Jun 10, 2024
11 checks passed
@emma-imber emma-imber deleted the ei/delete-redplanet branch June 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[beta] @guardian/commercial Add this label to publish an @guardian/commercial beta npm release from a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants