-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete redplanet #1405
Delete redplanet #1405
Conversation
🦋 Changeset detectedLatest commit: faf9f66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ad load time test resultsFor Test conditions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹Big if ad load results are to be trusted, seems to be all over the place! in the changeset PR its 4400 🤔#1398 (comment)
Yeah there seems to be roughly 200-400ms variability between runs. I guess this PR is still a little quicker than the changeset one! Would be good to have a think about how we could make the testing a little more reliable |
🚀 0.0.0-beta-20240610112701 published to npm as a beta release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah the smell of freshly deleted code in the morning ✨
b34a824
to
faf9f66
Compare
What does this change?
Deletes all files related to the running of redplanet - this includes launchpad, which is used by the redplanet code.
There will also be PRs needed to delete the switch in frontend, and references to the switch in dotcom-rendering. We can also look to remove redplanet from the vendor list when these code changes have been made.
Why?
We have permission to remove redplanet from the site.
Ad load speed impact
Results on this PR are about 300ms quicker for consented.