Skip to content

Commit

Permalink
Add an error message if we can't pull DCR container image (#1736)
Browse files Browse the repository at this point in the history
* Add an error message if we can't pull DCR container image

* Add continue on error to capture exitcode and next step

* Update the error message

Co-authored-by: Ravi <[email protected]>

---------

Co-authored-by: Ravi <[email protected]>
  • Loading branch information
deedeeh and arelra authored Jan 10, 2025
1 parent 7615607 commit b9ffb75
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/e2e-playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,20 @@ jobs:
# This makes the commercial dev server available from inside the container
# Note that GHA provides a service container feature, but it does not support this argument
- name: Start DCR in a container
id: start-dcr-container
continue-on-error: true
run: |
/usr/bin/docker run -d \
--network host \
-p 3030:3030 \
-e "PORT=3030" \
-e "COMMERCIAL_BUNDLE_URL=http://localhost:3031/graun.standalone.commercial.js" \
ghcr.io/guardian/dotcom-rendering:main
echo "exitcode=$?" >> $GITHUB_OUTPUT
- name: Start DCR in a container step failed
if: ${{ failure() && steps.start-dcr-container.conclusion == 'failure' && steps.start-dcr-container.outputs.exitcode == 125 }}
run: echo "Unable to fetch a DCR container image from the registry. Run the DCR main build in order to create a new container image." && exit 1

- name: Install Playwright Browsers
run: pnpm playwright install --with-deps chromium
Expand Down

0 comments on commit b9ffb75

Please sign in to comment.