Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden @guardian/source peer dep requirements up to v6 #506

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Aug 28, 2024

What does this change?

Broaden the @guardian/source peer dep range from ^1.0.1 to >= 1.0.1 < 7. I've tested with v6 and the component rendering looks good (I've made an assumption that things are fine in the intermediate major versions too).

As per our recommendations I've bumped the dev version to the latest acceptable.

How to test

Check that Chromatic is happy.

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 98aa60d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@guardian/braze-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tjmw added 2 commits August 28, 2024 14:38
I've tested with v6 and all seems fine (so I also assume that the
intermediate versions work okay too).

This ought to make upgrading incrementally on DCR more straightforward.
Copy link

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom, looks good!

@tjmw tjmw changed the title Upgrade @guardian/source to v6 Broaden @guardian/source peer dep requirements up to v6 Aug 28, 2024
@tjmw tjmw merged commit 8f55394 into main Aug 28, 2024
9 checks passed
@tjmw tjmw deleted the tw/source-v6 branch August 28, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants